Skip to content

[PWGLF] Fix estimator parameters - #17486

Merged
romainschotter merged 3 commits into
masterfrom
njacazio-patch-1
Aug 21, 2026
Merged

[PWGLF] Fix estimator parameters#17486
romainschotter merged 3 commits into
masterfrom
njacazio-patch-1

Conversation

@njacazio

@njacazio njacazio commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwglf label Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix estimator parameters [PWGLF] Fix estimator parameters Aug 17, 2026
@alibuild alibuild mentioned this pull request Aug 17, 2026
Closed
@vkucera

vkucera commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

@njacazio Please create PRs from your fork repository to avoid polluting the upstream repository with references to personal branches.

@njacazio
njacazio marked this pull request as ready for review August 18, 2026 08:07
@alibuild

alibuild commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 28f7d5f at 2026-08-18 10:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:257:69: error: could not convert '{"enabledSpecies", {defaultParticles.std::array<std::array<int, 2>, 63>::operator[](0), o2::pwglf::PIDExtended::NIDsTot, (& defaultParticles.std::array<std::array<int, 2>, 63>::operator[](0))->std::array<int, 2>::size(), o2::pwglf::PIDExtended::arrayNames()(), {"Enable", "SelectPrimaries"}}, "Particles enabled"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<int> >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:260:73: error: could not convert '{"enabledEstimators", {defaultEstimators.std::array<std::array<int, 1>, 20>::operator[](0), Estimators::nEstimators, (& defaultEstimators.std::array<std::array<int, 1>, 20>::operator[](0))->std::array<int, 1>::size(), Estimators::arrayNames()(), {"Enable"}}, "Estimators enabled"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<int> >'
/sw/slc9_x86-64/O2/daily-20260818-0000-local1/include/Framework/StructToTuple.h:61:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(McParticlePrediction*&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 28f7d5f at 2026-08-18 10:16:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:257:69: error: could not convert '{"enabledSpecies", {defaultParticles.std::array<std::array<int, 2>, 63>::operator[](0), o2::pwglf::PIDExtended::NIDsTot, (& defaultParticles.std::array<std::array<int, 2>, 63>::operator[](0))->std::array<int, 2>::size(), o2::pwglf::PIDExtended::arrayNames()(), {"Enable", "SelectPrimaries"}}, "Particles enabled"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<int> >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:260:73: error: could not convert '{"enabledEstimators", {defaultEstimators.std::array<std::array<int, 1>, 20>::operator[](0), Estimators::nEstimators, (& defaultEstimators.std::array<std::array<int, 1>, 20>::operator[](0))->std::array<int, 1>::size(), Estimators::arrayNames()(), {"Enable"}}, "Estimators enabled"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<int> >'
/sw/slc9_x86-64/O2/daily-20260818-0000-local1/include/Framework/StructToTuple.h:61:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(McParticlePrediction*&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 28f7d5f at 2026-08-18 10:17:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:257:69: error: could not convert '{"enabledSpecies", {defaultParticles.std::array<std::array<int, 2>, 63>::operator[](0), o2::pwglf::PIDExtended::NIDsTot, (& defaultParticles.std::array<std::array<int, 2>, 63>::operator[](0))->std::array<int, 2>::size(), o2::pwglf::PIDExtended::arrayNames()(), {"Enable", "SelectPrimaries"}}, "Particles enabled"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<int> >'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:260:73: error: could not convert '{"enabledEstimators", {defaultEstimators.std::array<std::array<int, 1>, 20>::operator[](0), Estimators::nEstimators, (& defaultEstimators.std::array<std::array<int, 1>, 20>::operator[](0))->std::array<int, 1>::size(), Estimators::arrayNames()(), {"Enable"}}, "Estimators enabled"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<int> >'
/sw/slc9_x86-64/O2/daily-20260818-0000-local1/include/Framework/StructToTuple.h:61:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(McParticlePrediction*&)'
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft August 18, 2026 08:18
@njacazio
njacazio marked this pull request as ready for review August 21, 2026 08:43
@romainschotter
romainschotter enabled auto-merge (squash) August 21, 2026 09:25
@romainschotter
romainschotter merged commit 1cb25ed into master Aug 21, 2026
15 of 16 checks passed
@romainschotter
romainschotter deleted the njacazio-patch-1 branch August 21, 2026 11:18
@alibuild

alibuild commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d525e8e at 2026-08-21 14:23:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 22 errors and 3 warnings.'
Found 22 errors and 3 warnings.
++ [[ 22 -gt 0 ]]
++ cat /sw/BUILD/df2c4479dece8d8367051096fec6b37af259e7aa/O2Physics-code-check/errors.txt
PWGLF/Tasks/QC/mcParticlePrediction.cxx:122:40: error: variable 'enabledParticlesArray' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:123:40: error: variable 'selectPrimariesArray' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:182:43: error: variable 'enabledEstimatorsArray' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:206:59: error: variable 'hestimators' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:207:59: error: variable 'hestimatorsVsITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:208:59: error: variable 'hestimatorsVsETA05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:209:59: error: variable 'hestimatorsVsETA08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:210:59: error: variable 'hestimatorsVsImpactParameter' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:211:59: error: variable 'hestimatorsRecoEvGenVsReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:212:59: error: variable 'hestimatorsRecoEvGenVsReco_BCMC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:213:59: error: variable 'hestimatorsRecoEvGenVsRecoITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:214:59: error: variable 'hestimatorsRecoEvRecoVsITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:215:59: error: variable 'hestimatorsRecoEvRecoVsRecoITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:216:59: error: variable 'hestimatorsRecoEvRecoVsRecoITS_BCMC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:217:59: error: variable 'hestimatorsRecoEvRecoVsFT0A' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:218:59: error: variable 'hestimatorsRecoEvRecoVsBCId' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:219:59: error: variable 'hestimatorsRecoEvVsBCId' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:220:59: error: variable 'hvertexPosZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:221:93: error: variable 'hpt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:222:93: error: variable 'hy' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:223:93: error: variable 'heta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:224:93: error: variable 'hyield' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/df2c4479dece8d8367051096fec6b37af259e7aa/O2Physics-code-check/warnings.txt
PWGLF/Tasks/QC/mcParticlePrediction.cxx:150:26: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:256:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:259:54: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
++ [[ 22 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romainschotter romainschotter romainschotter approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@mario-krueger mario-krueger Awaiting requested review from mario-krueger mario-krueger is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@njacazio @vkucera @alibuild @romainschotter